Hi guys, sometimes I try something new to compare with already used packages, this weekend I wanted to try Eglot, however, I ran into a number of problems. One of them is autocomplete.

For example, when I write in vue, I want to autocomplete a watch function. This function is available in the following packages

import { watch } from 'vue';
import { watch } from 'fs';
import { watch } from 'fs/promises'
... etc

But when I use autocomplete in eglot I only see the first candidate - importing from the fs package. Is there any possibility or workaround to display all possible candidates?

Example of autocomplete with eglot

https://preview.redd.it/tlgtg5imw43c1.jpg?width=2930&format=pjpg&auto=webp&s=7f0cd2ff1b6733ec26021b77b6e5e392f26921df

Example of autocomplete with lsp-mode

https://preview.redd.it/rcntp2vow43c1.jpg?width=1224&format=pjpg&auto=webp&s=a246d790c47b4d48a3fba5e5f1cb361841eccc02

I also know that lsp-mode in conjunction with corfu has a similar problem, but it is impossible to solve it there as the authors of both packages think that the problem is not on their side 😅 Is the situation with eglot the same?

  • JDRiverRun@alien.topB
    link
    fedilink
    English
    arrow-up
    1
    ·
    1 year ago

    I’d also worry that an eq test is a bit fragile, and could go mysteriously wrong if any step in the chain decided down the road to copy or duplicate the string.

    • minad-emacs@alien.topB
      link
      fedilink
      English
      arrow-up
      1
      ·
      1 year ago

      It is not only fragile, it is also wrong, since the default completion UI even deletes duplicate candidates.

    • hvis@alien.topB
      link
      fedilink
      English
      arrow-up
      1
      ·
      1 year ago

      Something like that would be generally easy to see very soon (completion popup without both icons and annotations). This approach has worked for years for both Emacs’s default UI and company-mode, so it’s hard to call it fragile.

      I suppose it might have been a cause for investigation for some backend authors at some point, but backends would generally avoid internal copying anyway, for performance reasons if nothing else.

    • hvis@alien.topB
      link
      fedilink
      English
      arrow-up
      1
      ·
      1 year ago

      Actually, I forgot how this works in most cases X-D.

      And it happens through text properties, which backends add to their completion strings. Then the annotation and kind operations look them up.

      • JDRiverRun@alien.topB
        link
        fedilink
        English
        arrow-up
        1
        ·
        1 year ago

        Makes sense. I thought in the past the default completion system stripped out text properties? But I dimly recall that situation changed recently (v29?).